-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix systemctl is active #773
Conversation
I'd like to see this fixed. It's affecting a project with which I'm involved at work (#775). I suppose I'll have to do some lame workarounds. :-( |
@philpep Hi Philippe, is this project looking for maintainers/reviewers? Seems like the open PRs are a bit stuck.. |
This also applies to |
I am affected by this too. I checked the changes and they look fine to me. |
Signed-off-by: Amir Rossert <[email protected]>
Signed-off-by: Amir Rossert <[email protected]>
149f42e
to
4018bdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think previous behavior (AssertionError) was fine. But I'm also fine with the new proposed behavior. so LGTM.
Merged, thanks! |
Thanks @philpep |
A fix for this issue
#748